Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Wire onBlur on mobile blocks and components #12370

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Nov 27, 2018

This PR adds the onBlur method to mobile blocks and components, so that when their native side counterpart (AztecWrapper or TextInput) call onBlur due to focus lost, the ReactNative side can signal that, and unselect the block => Toolbar is going to be dismissed accordingly, and other things like that.

To test this PR follow the steps in the GB-mobile companion PR here: wordpress-mobile/gutenberg-mobile#283

@daniloercoli daniloercoli requested a review from mzorz November 27, 2018 18:36
@daniloercoli daniloercoli changed the title [RNMobile] Wire onBlur on mobile ported blocks and Components [RNMobile] Wire onBlur on mobile blocks and components Nov 27, 2018
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniloercoli daniloercoli merged commit c014e04 into master Nov 28, 2018
@daniloercoli daniloercoli deleted the rnmobile/wire-onBlur branch November 28, 2018 09:51
@youknowriad youknowriad added this to the 4.7 milestone Nov 29, 2018
@mtias mtias added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 1, 2018
@mtias mtias modified the milestones: 4.7, Mobile Alpha Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants